Skip to content

[Fix] Discord review resolutions appear as full-size text #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-lxs merged 2 commits into from
Aug 13, 2026
Merged

[Fix] Discord review resolutions appear as full-size text #1305

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aff9f7
fix: render Discord review resolutions as subtext
roomote Aug 13, 2026
400e53e
fix: format empty Discord review resolutions
roomote Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions apps/api/src/handlers/discord/__tests__/pr-review-action.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions apps/api/src/handlers/discord/pr-review-action.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,19 @@ export async function handleDiscordPrReviewActionCallback(input: {
if (!content) return reply(resolution);
Comment thread
roomote-community[bot] marked this conversation as resolved.
Outdated

const separator = '\n\n';
const formattedResolution = `-# ${resolution}`;
const availableContentLength =
DISCORD_MAX_MESSAGE_LENGTH - separator.length - resolution.length;
DISCORD_MAX_MESSAGE_LENGTH -
separator.length -
formattedResolution.length;
const preservedContent =
content.length <= availableContentLength
? content
: availableContentLength > 3
? `${content.slice(0, availableContentLength - 3)}...`
: content.slice(0, Math.max(availableContentLength, 0));

return reply(`${preservedContent}${separator}${resolution}`);
return reply(`${preservedContent}${separator}${formattedResolution}`);
};
const user = input.interaction.member?.user ?? input.interaction.user;
const mappedUserId = await findDiscordMappedUserId(user?.id);
Expand Down
Loading