[Fix] PR review notifications are lost during pull request creation - #1268
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
[Fix] PR review notifications are lost during pull request creation#1268roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
Contributor
Author
|
Closing as superseded by #1262, which covers the same association race with queue-backed bounded reconciliation and deterministic replay deduplication. |
roomote-roomote
Bot
deleted the
fix/pr-review-association-race-0s87mw6d7ubg8
branch
August 12, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
A review webhook could arrive after pull request creation succeeded but before its task association became visible. The initial lookup then treated the pull request as unrelated and permanently discarded the notification.
Impact
Review activity arriving during pull request association persistence is retained and scheduled once. Unrelated pull requests still exit after a short bounded lookup, and the change requires no schema migration or durable event system.
Package-wide SDK lint remains blocked by three pre-existing unused-disable warnings in untouched files; lint on all touched files passes.