Skip to content

[Fix] PR review feedback notifications disappear during long-running tasks #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote-roomote wants to merge 1 commit into from
Closed

[Fix] PR review feedback notifications disappear during long-running tasks #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions apps/bullmq/src/jobs/pr-review-notification.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions apps/bullmq/src/jobs/pr-review-notification.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,8 @@ export const prReviewNotificationJob = async (
}

console.warn(

@roomote-community roomote-community Bot Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cap is reached after the pending-list TTL for ordinary activity: enqueue waits one minute before the first run, then 288 five-minute deferrals put this branch at about 24h01m, while appendPendingEventAndClaimSchedule() expires the list after exactly 24h. By then consumePendingPrReviewActivity() returns an empty batch, so this still drops the feedback in the long-running case. Lower the cap with a buffer or refresh/extend the pending-event TTL while deferring.

`[PrReviewNotification] Task ${data.taskId} never went idle after ${data.deferrals} deferrals, dropping pending review activity for ${data.repository}#${data.prNumber}`,
`[PrReviewNotification] Task ${data.taskId} never went idle after ${data.deferrals} deferrals; delivering pending review activity for ${data.repository}#${data.prNumber}`,
);
await consumePendingPrReviewActivity(target);
return;
}

if (isExecutingTurn && isWorkerHeartbeatStale) {
Expand Down
Loading