Skip to content

Fix child task compute provider inheritance #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-lxs merged 1 commit into from
Aug 11, 2026
Merged

Fix child task compute provider inheritance #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions apps/api/src/handlers/tasks/__tests__/launchTask.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 26 additions & 1 deletion apps/api/src/handlers/tasks/launchTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ import {
inArray,
repositories,
resolveWorkspaceRepositoryProviders,
taskRuns,
} from '@roomote/db/server';
import {
ADMIN_REQUIRED_LAUNCH_TYPES,
ALL_REPOSITORIES,
buildTaskTypePromptAndWorkspacePayload,
type ComputeProvider,
getEnvironmentRepositoryInstallationError,
type StandardTask,
type SuggestedTasksTask,
Expand Down Expand Up @@ -125,6 +127,25 @@ async function resolveLaunchSourceControlProvider({
return undefined;
}

async function resolveLaunchComputeProvider({
requestedProvider,
auth,
}: {
requestedProvider: ComputeProvider | undefined;
auth: McpAuth;
}): Promise<ComputeProvider | undefined> {
if (requestedProvider || !('runId' in auth.authContext)) {
return requestedProvider;
}

const sourceRun = await db.query.taskRuns.findFirst({
where: eq(taskRuns.id, auth.authContext.runId),
columns: { vendor: true },
});

return sourceRun?.vendor ?? undefined;
}

/**
* POST /api/tasks
*
Expand Down Expand Up @@ -284,6 +305,10 @@ export async function launchTask(
requestedType === 'standard' ? body.bootstrap?.skill : undefined,
userId: auth.userId,
});
const computeProvider = await resolveLaunchComputeProvider({
requestedProvider: body.computeProvider,
auth,
});

// A settle notification needs a durable pointer back to the launching
// run, so the opt-in only takes effect on run-token launches.
Expand All @@ -294,7 +319,7 @@ export async function launchTask(

const taskBase = {
harness: harnessSelection.harness ?? body.harness,
computeProvider: body.computeProvider,
computeProvider,
requestedWorkKindDecision,
...((requestedType === 'environment-definition' ||
notifySourceRunOnSettle) &&
Expand Down
Loading