[Feat] Connect OAuth clients to Roomote member tools - #1219
Merged
Conversation
Contributor
|
No new code issues found. See task
Reviewed b2b34b1 |
Contributor
Author
|
The refresh-session family isolation finding is fixed in 24d6527. Each browser authorization now creates a fresh random token family. An atomic per-member/client pointer retires the prior active family, so a replay marker from an older authorization can only affect that old family and cannot revoke its replacement. Focused tests cover replacement-family isolation, the real Redis lifecycle check passes, and the full pre-push lint, type, and dead-code checks pass. The review thread is resolved and the draft PR metadata reflects the shipped behavior. |
mrubens
marked this pull request as ready for review
August 11, 2026 21:50
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 11, 2026 21:50
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/mcpURL and proxied Streamable HTTP requests to the API servicehttps://<ROOMOTE_DOMAIN>/mcpWhy this change was made
OAuth-capable MCP clients need one stable Roomote URL and credentials that survive short access-token expiry without repeated browser authorization. Live Claude connection testing also exposed that successful consent could still fail at token exchange because the separately bundled token route had not initialized its signing keys.
Impact
Users can connect Claude Code, Claude connectors, Cursor, VS Code, and other compatible clients to
https://<ROOMOTE_DOMAIN>/mcp. Browser authorization now completes through token exchange, supported clients remain connected through securely rotated refresh tokens, and replaying a token from an older authorization cannot revoke its replacement session.