Skip to content

[Feat] Add Doctor environment health workflow - #1211

Merged
daniel-lxs merged 18 commits into
developfrom
feature/roomote-doctor-stage-1-2pn4eufsz7zae
Aug 12, 2026
Merged

[Feat] Add Doctor environment health workflow#1211
daniel-lxs merged 18 commits into
developfrom
feature/roomote-doctor-stage-1-2pn4eufsz7zae

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Added an explicitly invoked $doctor workflow for environment-health investigations.
  • Doctor resolves the exact linked environment and launches an ordinary, read-only Roomote task against it through the existing manage_tasks MCP surface.
  • Verification is goal-driven and repository-aware rather than a fixed technology checklist. It monitors real environment setup plus the child task's explicit ready, not_ready, or blocked result.
  • Added ownership classification for environment configuration, repository, Roomote platform, external dependency, and undetermined failures.
  • Kept Doctor read-only by default. Authorized repairs continue through the existing environment-setup or implementation workflows and require fresh post-repair verification.
  • Added conditional layered preview checks, including browser console and journey-critical network inspection, without assuming every workload is a web app.
  • Prevented recursive Doctor launches from environment verification tasks.
  • Made task summaries expose the linked environment for ordinary task payloads and normalized blank optional branch values in task launches.

Why

An environment-health workflow should prove the same path users depend on: selecting an environment, scheduling compute, preparing the workspace, starting the intended workload, and completing the requested journey. A fresh ordinary task provides that end-to-end evidence without introducing a technology-specific diagnostic API that duplicates agent capabilities.

Validation

  • Focused worker, cloud-agent, API, types, and dev workflow tests
  • Package type-checking
  • Full pre-push lint, fast type-check, and knip gate
  • Local end-to-end verification with a fresh parent Doctor task and ordinary child task on Local Docker

@roomote-community

roomote-community Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • Preserve query strings and fragments from initial_path in diagnostics (apps/worker/src/mcp/roomote-mcp-server/diagnose-environment.ts:541).
  • Make pre-persistence diagnostics evaluate the drafted environment definition, or remove that ineffective gate (packages/cloud-agents/src/server/workflows/skills/standard/environment-setup/SKILL.md:151).
  • Do not retain a completion criterion that marks a completed verification child ready without its explicit evidence-backed ready result (packages/cloud-agents/src/server/workflows/skills/standard/environment-setup/SKILL.md:221).
  • Redact final Doctor report fields before returning structured content (apps/worker/src/mcp/roomote-mcp-server/index.ts:114).

Reviewed b0a0884

Comment thread apps/worker/src/mcp/roomote-mcp-server/diagnose-environment.ts Outdated
@roomote-roomote

roomote-roomote Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Fixed both review findings in 9c8474fb:

  • Reused the shared appendInitialPath helper so diagnostic requests preserve pathname, query, and fragment components, with regression coverage for /?path=/story/example#anchor.
  • Removed the ineffective pre-persistence Doctor gate; structured diagnostics now run only in the persisted environment verification task after setup settles.

Targeted tests, pnpm lint, pnpm check-types, and pre-push checks pass. Both review threads are resolved.

@roomote-roomote roomote-roomote Bot changed the title [Feat] Add structured environment diagnostics [Feat] Add Doctor environment assessment workflow Aug 11, 2026
@daniel-lxs
daniel-lxs force-pushed the feature/roomote-doctor-stage-1-2pn4eufsz7zae branch from f1be0ab to 9be7097 Compare August 11, 2026 20:31
Comment thread apps/worker/src/mcp/roomote-mcp-server/index.ts Outdated
@daniel-lxs daniel-lxs changed the title [Feat] Add Doctor environment assessment workflow [Feat] Add Doctor environment health workflow Aug 12, 2026
@daniel-lxs
daniel-lxs marked this pull request as ready for review August 12, 2026 00:06
@daniel-lxs
daniel-lxs force-pushed the feature/roomote-doctor-stage-1-2pn4eufsz7zae branch from 9055abf to b0a0884 Compare August 12, 2026 16:04
@daniel-lxs
daniel-lxs merged commit 7a8b8a9 into develop Aug 12, 2026
19 checks passed
@daniel-lxs
daniel-lxs deleted the feature/roomote-doctor-stage-1-2pn4eufsz7zae branch August 12, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant