[Fix] Task runs complete twice after duplicate terminal events - #1183
Merged
daniel-lxs merged 1 commit intoAug 9, 2026
Merged
Conversation
Contributor
daniel-lxs
marked this pull request as ready for review
August 9, 2026 21:25
daniel-lxs
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 9, 2026 21:25
daniel-lxs
approved these changes
Aug 9, 2026
daniel-lxs
deleted the
fix/lifecycle-pr-review-reliability-1vxwr851dogfl
branch
August 9, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
The fixes in #1157 and #1170 covered paired idle handling and stale-heartbeat notification release independently. Exercising those paths as lifecycle sequences exposed that a duplicate terminal event could still finalize an already settled harness turn twice.
Impact
Live turns retain the existing debounce and deferral behavior, including during replacement-worker recovery. Pending review feedback is released after a dead worker and delivered once, while each real harness turn now produces one run completion even if its terminal event is replayed. Focused worker and BullMQ lifecycle suites, package typechecks, formatting, and the repository pre-push checks pass.