[Refactor] Split local model discovery out of task-models settings#536
Merged
mrubens merged 2 commits intoJul 18, 2026
Merged
Conversation
Move Ollama/vLLM/LiteLLM discovery, recommendation scoring, and qualification into a dedicated module so settings commands stay thin.
Contributor
Author
mrubens
marked this pull request as ready for review
July 18, 2026 15:11
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 18, 2026 15:11
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Follow-up to the self-hosted inference work in #481: local endpoint discovery had grown into the task-models settings command monofile.
Why this PR exists
What changed
Extracts Ollama, vLLM, and LiteLLM model discovery, recommendation scoring, and qualify probes out of the task-models settings command module into a dedicated local-provider discovery helper.
tRPC command entry points stay as thin admin wrappers with the same public APIs. Endpoint provider ids and connection env var names now come from the shared setup provider catalog instead of a second hard-coded list.
Matching discovery, scoring, and qualification tests moved with the extraction. Behavior should be unchanged for operators connecting local/endpoint providers.
How it was tested
Impact
No intended user-facing behavior change. Maintainers get a smaller settings command module and a clear place to extend local/endpoint discovery without mixing it with settings CRUD.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset