Skip to content

[Refactor] Split local model discovery out of task-models settings#536

Merged
mrubens merged 2 commits into
developfrom
refactor/split-local-model-discovery-16yqlripw7w18
Jul 18, 2026
Merged

[Refactor] Split local model discovery out of task-models settings#536
mrubens merged 2 commits into
developfrom
refactor/split-local-model-discovery-16yqlripw7w18

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote-roomote or in the web UI.

Related issue

Follow-up to the self-hosted inference work in #481: local endpoint discovery had grown into the task-models settings command monofile.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Extracts Ollama, vLLM, and LiteLLM model discovery, recommendation scoring, and qualify probes out of the task-models settings command module into a dedicated local-provider discovery helper.

tRPC command entry points stay as thin admin wrappers with the same public APIs. Endpoint provider ids and connection env var names now come from the shared setup provider catalog instead of a second hard-coded list.

Matching discovery, scoring, and qualification tests moved with the extraction. Behavior should be unchanged for operators connecting local/endpoint providers.

How it was tested

  • Targeted web Vitest for local-provider discovery and task-models commands (46 passed)
  • Web package typecheck
  • Pre-push gates: oxlint, residual lint, check-types:fast, knip

Impact

No intended user-facing behavior change. Maintainers get a smaller settings command module and a clear place to extend local/endpoint discovery without mixing it with settings CRUD.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

roomote added 2 commits July 18, 2026 12:51
Move Ollama/vLLM/LiteLLM discovery, recommendation scoring, and
qualification into a dedicated module so settings commands stay thin.
@roomote-roomote

roomote-roomote Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed 17f5f44

@mrubens
mrubens marked this pull request as ready for review July 18, 2026 15:11
@mrubens
mrubens merged commit d4341bc into develop Jul 18, 2026
17 checks passed
@mrubens
mrubens deleted the refactor/split-local-model-discovery-16yqlripw7w18 branch July 18, 2026 15:12
@roomote-roomote roomote-roomote Bot mentioned this pull request Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants