[Improve] Allow trailing punctuation on kickoff messages#353
Merged
mrubens merged 2 commits intoJul 15, 2026
Conversation
Router prompts and shared kickoff normalization now treat started messages as short complete sentences that terminate with punctuation.
Remove router instructions that ban trailing periods, and stop stripping them during kickoff normalization so model punctuation can surface in chat.
Contributor
Author
mrubens
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — internal product copy change from maintainer request.
Why this PR exists
What changed
Stop forbidding trailing punctuation on router kickoff messages.
normalizeKickoffMessagefrom stripping trailing periods so freeform kickoffs keep the model’s punctuationHow it was tested
pnpm --filter @roomote/communication exec vitest run src/__tests__/chat-messages.test.tspnpm --filter @roomote/slack exec vitest run src/__tests__/block-kit.test.tsChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetImpact
When the router writes a short kickoff sentence with a trailing period, chat started messages can show that period instead of forcing a period-free status phrase.