Skip to content

[Improve] Allow trailing punctuation on kickoff messages#353

Merged
mrubens merged 2 commits into
developfrom
improve/kickoff-sentence-punctuation-26eymqdber8fc
Jul 15, 2026
Merged

[Improve] Allow trailing punctuation on kickoff messages#353
mrubens merged 2 commits into
developfrom
improve/kickoff-sentence-punctuation-26eymqdber8fc

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

N/A — internal product copy change from maintainer request.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Stop forbidding trailing punctuation on router kickoff messages.

  • Removed the “no trailing period” rule from the routing prompt, response schema, and router eval prompt
  • Stopped normalizeKickoffMessage from stripping trailing periods so freeform kickoffs keep the model’s punctuation
  • Existing safety normalization (mentions, quotes, length) is unchanged

How it was tested

  • pnpm --filter @roomote/communication exec vitest run src/__tests__/chat-messages.test.ts
  • pnpm --filter @roomote/slack exec vitest run src/__tests__/block-kit.test.ts

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Impact

When the router writes a short kickoff sentence with a trailing period, chat started messages can show that period instead of forcing a period-free status phrase.

mrubens added 2 commits July 15, 2026 01:38
Router prompts and shared kickoff normalization now treat started messages as short complete sentences that terminate with punctuation.
Remove router instructions that ban trailing periods, and stop stripping them during kickoff normalization so model punctuation can surface in chat.
@roomote-roomote

roomote-roomote Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed 1881428

@mrubens mrubens marked this pull request as ready for review July 15, 2026 01:48
@mrubens mrubens merged commit 5e89e1c into develop Jul 15, 2026
18 checks passed
@mrubens mrubens deleted the improve/kickoff-sentence-punctuation-26eymqdber8fc branch July 15, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant