Fix type instability with high thread counts #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical type instability bug that was introduced when replacing
CPUSummary.sys_threads()withThreads.nthreads()in PR JuliaSIMD#28.The Problem
With the current implementation, when using more than 64 threads:
worker_bits()returns a regularInt64instead ofStaticIntworker_mask_count()which also returnsInt64_request_threadsfunction expectsStaticInt{N}but receivesInt64, causing aMethodErrorThe Solution
This PR makes the following changes:
worker_bits()to always returnIntfor consistencyworker_mask_count()to use regular integer division (cld)_request_threadsmethod that handlesIntparametersTesting
The fix has been tested with:
Before the fix:
After the fix:
Compatibility
The fix maintains backward compatibility while ensuring the code works correctly with any number of threads.
🤖 Generated with Claude Code