-
Notifications
You must be signed in to change notification settings - Fork 11
Fix 2-digit year timestamp parsing, sync error reporting, and captures columns #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cdd94d3
7efc24b
1a25c84
dbb28ca
c19cd73
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1106,6 +1106,7 @@ class Meta: | |
| "deployment", | ||
| "event", | ||
| "url", | ||
| "path", | ||
| # "thumbnail", | ||
| "timestamp", | ||
| "width", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,6 +134,18 @@ export const columns: (projectId: string) => TableColumn<Capture>[] = ( | |
| <BasicTableCell value={item.dimensionsLabel} /> | ||
| ), | ||
| }, | ||
| { | ||
| id: 'filename', | ||
| name: translate(STRING.FIELD_LABEL_FILENAME), | ||
| sortField: 'path', | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this should be updated to
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. However filename isn't actually a field in the DB. Do you think people will want to sort on filename only without the folder (the path)? It will have some performance impact to make a dynamic annotation field to allow sorting on just filename.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I understand! I don't think this is important to have. To avoid confusions though, I suggest we simply exclude sorting by this column: #1171 We can still allow users to sort by path (but then by applying sorting on this column directly)! :) |
||
| renderCell: (item: Capture) => <BasicTableCell value={item.filename} />, | ||
| }, | ||
| { | ||
| id: 'path', | ||
| name: translate(STRING.FIELD_LABEL_PATH), | ||
| sortField: 'path', | ||
mihow marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| renderCell: (item: Capture) => <BasicTableCell value={item.path} />, | ||
| }, | ||
| { | ||
| id: 'occurrences', | ||
| name: translate(STRING.FIELD_LABEL_OCCURRENCES), | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.