Open
Conversation
PatelVishakh
approved these changes
Dec 18, 2025
PatelVishakh
left a comment
There was a problem hiding this comment.
Assignment 1: Complete. Great work!
Suggested Changes:
Q1)
When answering questions rather then commenting in after manually reading the output, should automate it. for eg.
Number of observations (rows)
num_observations = wine_df.shape[0]
print(f"Number of observations: {num_observations}")
Owner
Author
|
Dear Vishakh,
Thank you for the feedback.
…On Thu, Dec 18, 2025 at 6:21 AM PatelVishakh ***@***.***> wrote:
***@***.**** approved this pull request.
Assignment 1: Complete. Great work!
Suggested Changes:
Q1)
When answering questions rather then commenting in after manually reading
the output, should automate it. for eg.
Number of observations (rows)
num_observations = wine_df.shape[0]
print(f"Number of observations: {num_observations}")
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BZEV2IP3TPB3G57CXKLPKR34CKE3TAVCNFSM6AAAAACPIILS7CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOJSGMYTEMZQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports) adding code
What did you learn from the changes you have made? I learnt the importance of standardizing the predictor variables
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of? I was not thinking of any other approach. The approach I used was fine.
Were there any challenges? If so, what issue(s) did you face? How did you overcome it? Yes I had some challenges in the process of writing my codes. While running the codes, I had error messages, which I had to look into following the highlighted errors and using the help () function till I got it right.
How were these changes tested? I ran the codes again after figuring out the cause of the errors.
A reference to a related issue in your repository (if applicable)
Checklist