-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[Outgunned} Bugfix: Accommodate PROD Environment #14389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Code changed to try to work around differences between PROD and TEST enviroments
Character Sheet Info Roll20 Internal Use only. |
I’m hoping to eventually receive word from Roll20 marketing as to the proper way to attribute PowerCoin images that they have granted permission to use. They requested that their company name, and possibly a URL to the site, be included (#351167). |
You should just leave the attribution in the |
Thanks Nora!
While I appreciate you leaving it open, I get flustered trying to change
code on the fly. I would have to alter the coin flip responses for HTML
Elements in four places, atop of proper attribution in the sheet.json.
Could the code changes for fixing the Death Roulette (fingers crossed) and
the images being changed from links to locations go through today and I'll
update the coin images on Thursday (or next Tuesday)?
I do appreciate the consideration, so thanks again
…On Tue, Sep 30, 2025 at 2:17 PM Nora Cahill ***@***.***> wrote:
*NorWhal* left a comment (Roll20/roll20-character-sheets#14389)
<#14389 (comment)>
I’m hoping to eventually receive word from Roll20 marketing as to the
proper way to attribute PowerCoin images that they have granted permission
to use. They requested that their company name, and possibly a URL to the
site, be included (#351167).
You should just leave the attribution in the sheet.json's instructions
attribute. I will leave this open to let you add that!
—
Reply to this email directly, view it on GitHub
<#14389 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AU34SJ2YXKSZEKMWYGYJMHT3VLCMVAVCNFSM6AAAAACH3DZVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJTGMYDIMRZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Added coin images from PowerCoin (with permission) and also trying to make <img> elements with 'locations' work
Greetings Nora
The changes for the coin images have been made and 'committed' to GitHub
(hopefully).
Thanks,
William
On Tue, Sep 30, 2025 at 3:16 PM William Barker ***@***.***>
wrote:
… Thanks Nora!
While I appreciate you leaving it open, I get flustered trying to change
code on the fly. I would have to alter the coin flip responses for HTML
Elements in four places, atop of proper attribution in the sheet.json.
Could the code changes for fixing the Death Roulette (fingers crossed) and
the images being changed from links to locations go through today and I'll
update the coin images on Thursday (or next Tuesday)?
I do appreciate the consideration, so thanks again
On Tue, Sep 30, 2025 at 2:17 PM Nora Cahill ***@***.***>
wrote:
> *NorWhal* left a comment (Roll20/roll20-character-sheets#14389)
> <#14389 (comment)>
>
> I’m hoping to eventually receive word from Roll20 marketing as to the
> proper way to attribute PowerCoin images that they have granted permission
> to use. They requested that their company name, and possibly a URL to the
> site, be included (#351167).
>
> You should just leave the attribution in the sheet.json's instructions
> attribute. I will leave this open to let you add that!
>
> —
> Reply to this email directly, view it on GitHub
> <#14389 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AU34SJ2YXKSZEKMWYGYJMHT3VLCMVAVCNFSM6AAAAACH3DZVW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNJTGMYDIMRZGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Code changed to try to work around differences between PROD and TEST enviroments
Submission Checklist
Warning
Submission Checklist
Failure to complete this checklist in its entirety will result in your Pull Request being dismissed. If you have any questions, please feel free to create an issue.
Note
Draft Pull Requests
If you are unclear about any of the rules regarding the creation of character sheets, or need assistance from the Roll20 team, please feel free to create a Draft PR and request feedback. We'd much rather provide assistance than reject a PR.
Pull Request Title
Please format your pull request in the following way:
[Sheet Name] Change Type: Description
. For example:[D&D5e] New Feature: Adding dragons to dungeons
.Pull Request Content
New Sheet Details
Please complete this section if you are adding a new sheet to the repository.
If you are submitting a new sheet to the repository, please fill in any empty spaces indicated by [ ].
The name of this game is: [ ]
The publisher of this game is: [ ]
The name of this game system/family is: [ ]
The rules for this game can be found at the following location: [ ]
I have followed the Character Sheets Standards when building this sheet.
I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
Select EXACTLY One:
Changes / Description
Bugfixes: Accommodate Death Roulette checkboxes float in Prod environment
Since style attribute for checkbox elements disappeared in Production environment (Bug Report #350904), the primitive solution was to make divs, and position each checkbox via their div to the correct location previously denoted in the checkboxes style. Since these elements were now isolated, the trick to having all one side activate was not possible, hence requiring a new sheetworker.
Make images ‘locations’ instead of ‘links’
Remove Coin replacement HTML Element with actual Unicode image