Skip to content

Conversation

WilliamBarkerCoC
Copy link
Contributor

Code changed to try to work around differences between PROD and TEST enviroments

Submission Checklist

Warning

Submission Checklist
Failure to complete this checklist in its entirety will result in your Pull Request being dismissed. If you have any questions, please feel free to create an issue.

Note

Draft Pull Requests
If you are unclear about any of the rules regarding the creation of character sheets, or need assistance from the Roll20 team, please feel free to create a Draft PR and request feedback. We'd much rather provide assistance than reject a PR.

Pull Request Title

Please format your pull request in the following way: [Sheet Name] Change Type: Description. For example: [D&D5e] New Feature: Adding dragons to dungeons.

  • The pull request title clearly contains the name of the sheet I am editing.
  • The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).

Pull Request Content

  • The pull request makes changes to files in only one sub-folder.
  • The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)
  • The pull request does not, without express prior permission from affected parties, include any material that could be considered to infringe on a Publisher's intellectual property rights, such as logos, images, rules text or other rules content.

New Sheet Details

Please complete this section if you are adding a new sheet to the repository.

If you are submitting a new sheet to the repository, please fill in any empty spaces indicated by [ ].

  • The name of this game is: [ ]

    (e.g. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

  • The publisher of this game is: [ ]

    (e.g. Wizards of the Coast, Evil Hat)

  • The name of this game system/family is: [ ]

    (e.g. Dungeons & Dragons, FATE)

  • The rules for this game can be found at the following location: [ ]

    (e.g. a link to purchase, ISBN, Half-Price Books)

  • I have followed the Character Sheets Standards when building this sheet.

  • I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.

Select EXACTLY One:

  • This game is a traditionally published game.
  • This game is not a traditionally published game.
  • This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system. [ ADD DETAILS HERE ]

Changes / Description

Bugfixes: Accommodate Death Roulette checkboxes float in Prod environment
Since style attribute for checkbox elements disappeared in Production environment (Bug Report #350904), the primitive solution was to make divs, and position each checkbox via their div to the correct location previously denoted in the checkboxes style. Since these elements were now isolated, the trick to having all one side activate was not possible, hence requiring a new sheetworker.
Make images ‘locations’ instead of ‘links’
Remove Coin replacement HTML Element with actual Unicode image

Code changed to try to work around differences between PROD and TEST enviroments
@roll20deploy
Copy link
Contributor

Character Sheet Info Roll20 Internal Use only.

@WilliamBarkerCoC
Copy link
Contributor Author

I’m hoping to eventually receive word from Roll20 marketing as to the proper way to attribute PowerCoin images that they have granted permission to use. They requested that their company name, and possibly a URL to the site, be included (#351167).

@NorWhal
Copy link
Contributor

NorWhal commented Sep 30, 2025

I’m hoping to eventually receive word from Roll20 marketing as to the proper way to attribute PowerCoin images that they have granted permission to use. They requested that their company name, and possibly a URL to the site, be included (#351167).

You should just leave the attribution in the sheet.json's instructions attribute. I will leave this open to let you add that!

@WilliamBarkerCoC
Copy link
Contributor Author

WilliamBarkerCoC commented Sep 30, 2025 via email

Added coin images from PowerCoin (with permission) and also trying to make <img> elements with 'locations' work
@WilliamBarkerCoC
Copy link
Contributor Author

sheet.json now has the attribution. Also altered the elements, once again, to try to get 'locations, not links' to work. The new coin images are also active. Hopefully these changes will work in the Production environment

@WilliamBarkerCoC
Copy link
Contributor Author

WilliamBarkerCoC commented Oct 2, 2025 via email

@NorWhal NorWhal removed the blocked label Oct 2, 2025
@NorWhal NorWhal merged commit 01b9f94 into Roll20:master Oct 2, 2025
1 check passed
@WilliamBarkerCoC WilliamBarkerCoC deleted the Outgunned.wb2 branch October 2, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants