[Draw Steel] Sheet Worker Updates #14388
Open
+1,383
−2,689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Refactored ability and feature sharing sheet worker code - Reorganized code for readability - Moved Draw Steel logo to top of sheet so it will be displayed for both the character and NPC sheets - Changed styling on NPC ability edit checkboxes to be pencils.
- Cleaned up power roll sheet worker code. - Changed player ability cards use a dropdown for characteristics instead of text. Added dark mode coloring to new element. - removed unneeded placeholder properties from spans. - Altered the Power Roll template to include character name.
|
Character Sheet Info Roll20 Internal Use only. |
|
Hello @Zen-Raven, Your branch currently has merge conflicts that need to be addressed before we can merge this. Thank you! |
- Added comments to some sections for clarity - Removed edit ability from some of the standard abilities as they will not need to be edited. - Cleaned up sheet worker code for new standard abilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Warning
Submission Checklist
Failure to complete this checklist in its entirety will result in your Pull Request being dismissed. If you have any questions, please feel free to create an issue.
Note
Draft Pull Requests
If you are unclear about any of the rules regarding the creation of character sheets, or need assistance from the Roll20 team, please feel free to create a Draft PR and request feedback. We'd much rather provide assistance than reject a PR.
[Draw Steel] Sheet Worker Updates
Please format your pull request in the following way:
[Sheet Name] Change Type: Description. For example:[D&D5e] New Feature: Adding dragons to dungeons.Pull Request Content
Changes / Description
Sheet Worker Code
Various Updates