Skip to content

Conversation

@phmbressan
Copy link
Collaborator

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (make format) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Flights that do not reach apogee had their self.apogee attribute not initialized. Therefore, in exporting, the use of this attribute entails an error.

New behavior

The self.apogee is initialized as zero following other apogee pre-definitions (e.g. apogee state).

Breaking change

  • Yes
  • No

@phmbressan phmbressan added this to the Release v1.X.0 milestone Oct 25, 2025
@phmbressan phmbressan self-assigned this Oct 25, 2025
@phmbressan phmbressan requested a review from a team as a code owner October 25, 2025 21:13
@phmbressan phmbressan added the Outputs Dedicated to visualizations enhancements like prints and plots label Oct 25, 2025
@phmbressan phmbressan added the Flight Flight Class related features label Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (8797068) to head (a9ec005).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #863   +/-   ##
========================================
  Coverage    80.27%   80.27%           
========================================
  Files          104      104           
  Lines        12768    12769    +1     
========================================
+ Hits         10249    10250    +1     
  Misses        2519     2519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Backlog to Next Version in LibDev Roadmap Oct 26, 2025
@Gui-FernandesBR Gui-FernandesBR merged commit 857c4f4 into develop Oct 28, 2025
10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/export-non-apogee-flights branch October 28, 2025 14:03
@github-project-automation github-project-automation bot moved this from Next Version to Closed in LibDev Roadmap Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Flight Flight Class related features Outputs Dedicated to visualizations enhancements like prints and plots

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants