-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: react-compiler #6679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: react-compiler #6679
Changes from all commits
9241fb9
2c37e7c
2c73d2a
5790d8c
0e3549f
6c0b90c
05b4eb3
994f622
755bd8e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,8 @@ interface IListInfo { | |
| } | ||
|
|
||
| const ListInfo = React.memo(({ info, translateInfo = true }: IListInfo) => { | ||
| 'use memo'; | ||
|
|
||
|
Comment on lines
+28
to
+29
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid directive in memoized component.
🤖 Prompt for AI Agents |
||
| const { theme } = useTheme(); | ||
| return ( | ||
| <View style={styles.container}> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,8 @@ interface IListSeparator { | |
| } | ||
|
|
||
| const ListSeparator = React.memo(({ style }: IListSeparator) => { | ||
| 'use memo'; | ||
|
|
||
|
Comment on lines
+18
to
+19
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invalid directive in memoized component.
🤖 Prompt for AI Agents |
||
| const { theme } = useTheme(); | ||
|
|
||
| return <View style={[styles.separator, style, { backgroundColor: themes[theme].strokeLight }]} />; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -197,7 +197,7 @@ describe('MessageComposer', () => { | |
|
|
||
| rerender(<Render />); | ||
|
|
||
| expect(screen.getByTestId('message-composer-close-emoji')).toBeOnTheScreen(); | ||
| // expect(screen.getByTestId('message-composer-close-emoji')).toBeOnTheScreen(); | ||
| expect(screen.toJSON()).toMatchSnapshot(); | ||
|
Comment on lines
+200
to
201
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify the commented-out assertion. The emoji close button assertion was removed, weakening test coverage. Please confirm whether:
If the button still exists, restore the assertion. Run this verification script to check for the close button implementation: 🏁 Script executed: #!/bin/bash
# Search for the close emoji button implementation and test ID
rg -nP --type=tsx --type=ts -C3 'message-composer-close-emoji|closeEmoji|close.*emoji'Length of output: 27 🏁 Script executed: #!/bin/bash
# Search for 'message-composer-close-emoji' test ID in tsx files
rg -n -C3 'message-composer-close-emoji' -g '*.tsx'
# Search for any closeEmoji identifier variants
rg -n -C3 '\bcloseEmoji\b' -g '*.tsx'Length of output: 1311 Restore the emoji close button assertion in MessageComposer.test.tsx The component in app/containers/MessageComposer/components/Toolbar/EmojiKeyboard.tsx still renders expect(screen.getByTestId('message-composer-close-emoji')).toBeOnTheScreen();🤖 Prompt for AI Agents |
||
| }); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid directive in memoized component.
ListHeaderis already wrapped withReact.memo()on line 27. The'use memo';directive is both invalid and redundant.🤖 Prompt for AI Agents