-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(iOS): swipe back adds weird padding to Messages List #6676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+46
−2
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f7c4d14
fix: on navigate with keyboard opened and go back add a padding on ke…
OtavioStasiak c95c859
fix: onBlur changing isFocused and breaking the composer
OtavioStasiak ac7a1f2
chore: code improvements
OtavioStasiak bdc7e88
fix: snapshot test
OtavioStasiak 62582e9
Merge branch 'develop' into fix.padding-composer
OtavioStasiak 0dd5243
fix: setFocused and useOnBlur
OtavioStasiak d0eccd9
fix: snapshot test
OtavioStasiak 2b1789a
fix: navigation issue
OtavioStasiak 624b7f7
fix: edge case on navigate userInfo
OtavioStasiak a6dd5b8
chore: code improvements
OtavioStasiak e14918f
chore: code improvements
OtavioStasiak 9103895
chore: code improvements
OtavioStasiak 44db62d
Merge branch 'develop' into fix.padding-composer
OtavioStasiak 972e96b
fix: iOSBackSwipe reset
OtavioStasiak 21e5b53
fix: iOSBackSwipe reset
OtavioStasiak 7423163
fix: onback dismiss
OtavioStasiak f70347c
fix: blur
OtavioStasiak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
app/containers/MessageComposer/hooks/useIOSBackSwipeHandler.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { useEffect, useRef } from 'react'; | ||
| import { Keyboard } from 'react-native'; | ||
| import { useNavigation } from '@react-navigation/native'; | ||
|
|
||
| import { isIOS } from '../../../lib/methods/helpers'; | ||
|
|
||
| const useIOSBackSwipeHandler = () => { | ||
| const navigation = useNavigation(); | ||
| const iOSBackSwipe = useRef<boolean>(false); | ||
|
|
||
| useEffect(() => { | ||
| if (!isIOS) return; | ||
|
|
||
| const transitionStartListener = navigation.addListener('transitionStart' as any, e => { | ||
| if (e?.data?.closing) { | ||
| iOSBackSwipe.current = true; | ||
| Keyboard.dismiss(); | ||
| } | ||
| }); | ||
|
|
||
| const transitionEndListener = navigation.addListener('transitionEnd' as any, e => { | ||
| if (e?.data?.closing) { | ||
| iOSBackSwipe.current = false; | ||
| } | ||
| }); | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| return () => { | ||
| transitionStartListener(); | ||
| transitionEndListener(); | ||
| }; | ||
| }, []); | ||
|
|
||
| return { iOSBackSwipe }; | ||
| }; | ||
|
|
||
| export default useIOSBackSwipeHandler; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.