-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[doc] Update upgrades process with DEE automation #23790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[doc] Update upgrades process with DEE automation #23790
Conversation
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+a:@Aiden2244 for feature review, please.
Reviewable status: LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)
Aiden2244
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)
tools/workspace/README.md line 213 at r1 (raw file):
to create a pull request on drake-external-examples. See the script for its usage requirements; it mirrors the workflow of the `new_release` tooling.
Should we add a note here that, as a part of the monthly upgrades cycle, it is best to wait until after the first of the month to run this script? That way, it can be in sync with the latest upgrades from the drake renovate commits.
ccee2bf to
6acb414
Compare
That script has undergone several improvements, including CI, which should be consistently described here.
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)
tools/workspace/README.md line 213 at r1 (raw file):
Previously, Aiden2244 (Aiden McCormack) wrote…
Should we add a note here that, as a part of the monthly upgrades cycle, it is best to wait until after the first of the month to run this script? That way, it can be in sync with the latest upgrades from the drake renovate commits.
Great point, thanks! I've added another sentence on that. I didn't want to mention the first of the month as this README immediately bitrots if we change the schedule, so I just pointed to the renovate.json instead. Feel free to make additional suggestions on the language as needed.
Aiden2244
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, will kick off to platform reviewer next Monday.
@Aiden2244 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)
tools/workspace/README.md line 213 at r1 (raw file):
Previously, tyler-yankee (Tyler Yankee) wrote…
Great point, thanks! I've added another sentence on that. I didn't want to mention the first of the month as this README immediately bitrots if we change the schedule, so I just pointed to the
renovate.jsoninstead. Feel free to make additional suggestions on the language as needed.
The wording here seems good to me!
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge"
a discussion (no related file):
Working
@Aiden2244 Let's please wait to assign platform review until RobotLocomotion/drake-external-examples#474 is merged (or at very least feature-reviewed).
That script has undergone several improvements, including CI, which should be consistently described here.
Closes RobotLocomotion/drake-external-examples#432, see also: RobotLocomotion/drake-external-examples#474.
This change is