Skip to content

Conversation

@tyler-yankee
Copy link
Contributor

@tyler-yankee tyler-yankee commented Nov 14, 2025

That script has undergone several improvements, including CI, which should be consistently described here.

Closes RobotLocomotion/drake-external-examples#432, see also: RobotLocomotion/drake-external-examples#474.


This change is Reviewable

@tyler-yankee tyler-yankee added status: do not merge release notes: none This pull request should not be mentioned in the release notes labels Nov 14, 2025
Copy link
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@Aiden2244 for feature review, please.

Reviewable status: LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)

Copy link
Contributor

@Aiden2244 Aiden2244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)


tools/workspace/README.md line 213 at r1 (raw file):

to create a pull request on drake-external-examples. See the script for its
usage requirements; it mirrors the workflow of the `new_release` tooling.

Should we add a note here that, as a part of the monthly upgrades cycle, it is best to wait until after the first of the month to run this script? That way, it can be in sync with the latest upgrades from the drake renovate commits.

That script has undergone several improvements, including CI, which
should be consistently described here.
Copy link
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, LGTM missing from assignee Aiden2244, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)


tools/workspace/README.md line 213 at r1 (raw file):

Previously, Aiden2244 (Aiden McCormack) wrote…

Should we add a note here that, as a part of the monthly upgrades cycle, it is best to wait until after the first of the month to run this script? That way, it can be in sync with the latest upgrades from the drake renovate commits.

Great point, thanks! I've added another sentence on that. I didn't want to mention the first of the month as this README immediately bitrots if we change the schedule, so I just pointed to the renovate.json instead. Feel free to make additional suggestions on the language as needed.

Copy link
Contributor

@Aiden2244 Aiden2244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, will kick off to platform reviewer next Monday.

@Aiden2244 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @tyler-yankee)


tools/workspace/README.md line 213 at r1 (raw file):

Previously, tyler-yankee (Tyler Yankee) wrote…

Great point, thanks! I've added another sentence on that. I didn't want to mention the first of the month as this README immediately bitrots if we change the schedule, so I just pointed to the renovate.json instead. Feel free to make additional suggestions on the language as needed.

The wording here seems good to me!

Copy link
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge"


a discussion (no related file):
Working

@Aiden2244 Let's please wait to assign platform review until RobotLocomotion/drake-external-examples#474 is merged (or at very least feature-reviewed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: none This pull request should not be mentioned in the release notes status: do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[drake_cmake_external] Sync external dependency upgrades with Drake

2 participants