-
Notifications
You must be signed in to change notification settings - Fork 57
Update dependency python to v3.14.2 #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyler-yankee reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee tyler-yankee, platform LGTM missing (waiting on @renovate[bot])
a discussion (no related file):
Hmm. Seems that Renovate doesn't understand we define our Python version as a string environment variable e.g.
drake-external-examples/.github/workflows/pip.yml
Lines 12 to 13 in cb0360d
| env: | |
| PYTHON_VERSION: '3.14' |
Conceivably I could look into how to reconfigure the yaml to make Renovate happy while not losing functionality or readability. But in its current form, I'm not sure this PR is any substantial improvement.
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee tyler-yankee, platform LGTM missing (waiting on @tyler-yankee)
a discussion (no related file):
Previously, tyler-yankee (Tyler Yankee) wrote…
Hmm. Seems that Renovate doesn't understand we define our Python version as a string environment variable e.g.
. IIRC, I wrote that for portability so that you can change what version of Python you're using in the scripts themselves.drake-external-examples/.github/workflows/pip.yml
Lines 12 to 13 in cb0360d
env: PYTHON_VERSION: '3.14' Conceivably I could look into how to reconfigure the yaml to make Renovate happy while not losing functionality or readability. But in its current form, I'm not sure this PR is any substantial improvement.
This PR is for the private file_sync_test, not Drake tests.
tyler-yankee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee tyler-yankee, platform LGTM missing (waiting on @jwnimmer-tri)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
This PR is for the private file_sync_test, not Drake tests.
Yes, but (a) two patch versions will hardly matter for the file_sync_test, (b) they might as well all be using the same version, and (c) if we're expecting Renovate to bump the python-version for Drake in the future, it won't as currently written (because otherwise I imagine it would have applied across the board?).
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee tyler-yankee, platform LGTM missing (waiting on @tyler-yankee)
a discussion (no related file):
Previously, tyler-yankee (Tyler Yankee) wrote…
Yes, but (a) two patch versions will hardly matter for the
file_sync_test, (b) they might as well all be using the same version, and (c) if we're expecting Renovate to bump thepython-versionfor Drake in the future, it won't as currently written (because otherwise I imagine it would have applied across the board?).
(a) Yes, the patch version change is minor. The bigger question is, do we want Renovate to remind us to upgrade file_sync_test to python 3.15.0 when it comes out? If yes, then we need to merge this now to placate Renovate. If no, then we need to reconfigure it not to even try. Either way, action is required.
(b) Generally "uniform python version in all of DEE CI" is not 100% reachable. Typically our linux vs macOS upgrades of Python support are staggered in time and variable. Perhaps the rule you have in mind is that file_sync_test should be run on same version of Ubuntu as developers use? In which case the action is to downgrade it to 3.12, add a comment, and turn off Renovate for this one.
(c) Right. Separate question, though.
This PR contains the following updates:
3.14->3.14.2Release Notes
actions/python-versions (python)
v3.14.2: 3.14.2Compare Source
Python 3.14.2
v3.14.1: 3.14.1Compare Source
Python 3.14.1
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
This change is