Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default listener location description #1039

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rbxphogen
Copy link
Contributor

@rbxphogen rbxphogen commented Feb 28, 2025

Changes

Adds a description for SoundService.DefaultListenerLocation

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@rbxphogen rbxphogen requested a review from fumminger February 28, 2025 17:37
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Feb 28, 2025
@rbxphogen rbxphogen marked this pull request as ready for review February 28, 2025 17:52
@rbxphogen rbxphogen requested a review from a team as a code owner February 28, 2025 17:52
@IgnisRBX
Copy link
Contributor

IgnisRBX commented Feb 28, 2025

In cases like this, it would probably be better to move all of this info to the Enum.ListenerLocation page, which this property directly uses and is the sole user of. Could you please migrate each piece of this to that page and then I'll do some touch-ups from there? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine reference Changes the Engine API Reference documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants