Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for getManifest() #18

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Test for getManifest() #18

merged 10 commits into from
Aug 14, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Aug 13, 2024

Challenge: bun is unable to unmock a mocked module (fs in this case).
Workaround: globally available mocks dir with a readerMock used by the test of getManifest()

@RobinTail
Copy link
Owner Author

bun issue — addressing in #19

@RobinTail RobinTail changed the title Test for getManifest. Test for getManifest Aug 14, 2024
Copy link

coveralls-official bot commented Aug 14, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling dd5f725 on test-get-manifest
into 576fb11 on main.

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@RobinTail RobinTail marked this pull request as ready for review August 14, 2024 09:10
@RobinTail RobinTail changed the title Test for getManifest Test for getManifest() Aug 14, 2024
@RobinTail RobinTail merged commit 2369774 into main Aug 14, 2024
10 checks passed
@Jarred-Sumner
Copy link

Challenge: bun is unable to unmock a mocked module (fs in this case).

Have you tried jest.clearAllMocks()? Worst case you might need to do that and delete require.cache["fs"] but I don't think both are necessary

@RobinTail
Copy link
Owner Author

Here is no jest, but I'll try the suggested approach with a similar method of bun — thank you @Jarred-Sumner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants