BUG FIX: Buffer overflow due to arithmetic overflow in RLE decoding #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlSchlo
changed the title
|
@AlSchlo Do you have a reproducible test case we could use for testing ? |
|
@lemire The bug has been found in our in-house fuzz suite. I will see how we can reproduce locally to avoid regressions. |
|
@AlSchlo That would be much appreciated. |
|
@lemire After investigation, it seems that this bug has already been fixed here! We were using an older version before the patch went life. Given that all other places in the code replaced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title: experienced through my usage of CRoaring w/ ASan.
Interestingly, other places in the code have it correct, but somehow this must have slipped through the cracks.