Update Fibonnaci.js #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It will be much easier if you will add PR description for reviewing the changes done by you . |
|
As much I know both of the provided approaches have the same time and space complexity, as they follow the same algorithm for generating and printing Fibonacci numbers. |
|
Well just because it is Javascript, May be it will not throw an error, But it can throw error in production. For example , in the place of fi=null, if we take fi=undefined, the code will also run. But, adding a primitive datatypes "fi" will make the code readable. If you think that you don't want update it its ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.