fix: handle rate limit (429) and timeout errors in fetchJson - #1
Open
ygd58 wants to merge 1 commit into
Open
Conversation
- Add explicit 429 handling with a clear user-facing message instead of leaking raw HTTP error text when CoinGecko rate-limits the client - Catch AbortError separately so timeout failures surface a descriptive message rather than a generic network error
|
@ygd58 is attempting to deploy a commit to the 0xBuns Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two error handling gaps in
fetchJsoninsidetool/market-tool.ts:Problems
1. CoinGecko 429 rate limit — When the API returns HTTP 429, the existing code throws a raw error like
Market data request failed (429 Too Many Requests). This is confusing for end users who have no context on what to do.2. Timeout AbortError — When the request times out,
AbortControllerfires and throws anAbortError. This was not caught separately, so it surfaced as an unhandled error instead of a clear timeout message.Fix
res.status === 429and throw a user-friendly rate limit messageAbortErrorby name and throw a descriptive timeout message including the configured timeout duration