Skip to content

Add settings UseUriTypeForUriFormattedStrings #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herrahlstrom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add settings UseUriTypeForUriFormattedStrings #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/NJsonSchema.CodeGeneration.CSharp/CSharpGeneratorSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ public CSharpGeneratorSettings()
InlineNamedArrays = false;
InlineNamedDictionaries = false;
InlineNamedTuples = true;

UseUriTypeForUriFormattedStrings = true;
}

/// <summary>Gets or sets the .NET namespace of the generated types (default: MyNamespace).</summary>
Expand Down Expand Up @@ -147,5 +149,8 @@ public CSharpGeneratorSettings()

/// <summary>Generate C# 9.0 record types instead of record-like classes.</summary>
public bool GenerateNativeRecords { get; set; }

/// <summary>Indicate if System.Uri should be used for strings with format uri (default: true)</summary>
public bool UseUriTypeForUriFormattedStrings { get; set; }
}
}
2 changes: 1 addition & 1 deletion src/NJsonSchema.CodeGeneration.CSharp/CSharpTypeResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ private string ResolveString(JsonSchema schema, bool isNullable, string typeName

var nullableReferenceType = Settings.GenerateNullableReferenceTypes && isNullable ? "?" : string.Empty;

if (schema.Format == JsonFormatStrings.Uri)
if (schema.Format == JsonFormatStrings.Uri && Settings.UseUriTypeForUriFormattedStrings)
{
return "System.Uri" + nullableReferenceType;
}
Expand Down