FIX: Serialize parent categories first (discourse#26294)

When categories are loaded by the frontend, the parent category is looked up by ID and the `parentCategory` is set with the result. If the categories returned are not in order, the parent category may miss.
RickyC0626-forks · Mar 21, 2024 · a6e0691 · a6e0691
1 parent 2129e9e
commit a6e0691
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/models/topic_list.rb b/app/models/topic_list.rb
@@ -77,7 +77,7 @@ def topics
 
   def categories
     @categories ||=
-      topics.map { |t| [t.category&.parent_category, t.category] }.uniq.flatten.compact
+      topics.map { |t| [t.category&.parent_category, t.category] }.flatten.uniq.compact
   end
 
   def load_topics

diff --git a/lib/topic_view.rb b/lib/topic_view.rb
@@ -727,9 +727,9 @@ def summarizable?
   end
 
   def categories
-    categories = [category, category&.parent_category]
-    categories += suggested_topics.categories if suggested_topics
-    categories.compact.uniq
+    @categories ||= [category&.parent_category, category, suggested_topics&.categories].flatten
+      .uniq
+      .compact
   end
 
   protected