FIX: Remove multiple consecutive dashes from tag names (discourse#24520)

RickyC0626-forks · Nov 22, 2023 · 9f3399c · 9f3399c
1 parent fef14c0
commit 9f3399c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/discourse_tagging.rb b/lib/discourse_tagging.rb
@@ -724,8 +724,8 @@ def self.clean_tag(tag)
     tag.strip!
     tag.gsub!(/[[:space:]]+/, "-")
     tag.gsub!(/[^[:word:][:punct:]]+/, "")
-    tag.squeeze!("-")
     tag.gsub!(TAGS_FILTER_REGEXP, "")
+    tag.squeeze!("-")
     tag[0...SiteSetting.max_tag_length]
   end
 

diff --git a/spec/lib/discourse_tagging_spec.rb b/spec/lib/discourse_tagging_spec.rb
@@ -1479,6 +1479,11 @@
       it "removes zero-width spaces" do
         expect(DiscourseTagging.clean_tag("hel\ufefflo")).to eq("hello")
       end
+
+      it "removes multiple consecutive dashes" do
+        expect(DiscourseTagging.clean_tag("hello---world")).to eq("hello-world")
+        expect(DiscourseTagging.clean_tag("Finances & Accounting")).to eq("finances-accounting")
+      end
     end
   end