Fix event test unsubscribing from wrong subscription #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the event test where the test was unsubscribing from an incorrect subscription object. The fix ensures the proper subscription is unsubscribed from during test cleanup.
- Fixed incorrect subscription variable reference in test cleanup
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| STRTOFILE("DDD",lcFile) | ||
| STRTOFILE("FFF",lcFile) | ||
| loLoopbackEventSubscription.Unsubscribe() | ||
| loFwSubscription.Unsubscribe() |
There was a problem hiding this comment.
The fix assumes that loFwSubscription is the correct subscription object to unsubscribe from. However, without seeing the full test context, verify that loFwSubscription is properly initialized and is the intended subscription object for this test scenario.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.