feat: implement multisig-initialization-validation#239
Merged
thlpkee20-wq merged 8 commits intoRevoraOrg:masterfrom Apr 1, 2026
Merged
Conversation
|
@lycantho Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@thlpkee20-wq please merge |
lycantho
force-pushed
the
feature/contracts-017-multisig-initialization-validation
branch
2 times, most recently
from
9636041 to
1b946dc
Compare
lycantho
force-pushed
the
feature/contracts-017-multisig-initialization-validation
branch
from
1b946dc to
4cace93
Compare
Contributor
Author
|
@thlpkee20-wq the workflow error is not my code |
Contributor
Author
|
@thlpkee20-wq i have managed to fix the workflow, now it can be merged please |
Contributor
|
Please resolve the conflicts |
…ation-validation Resolved conflicts in: - src/lib.rs: kept multisig init validation logic, restored orphaned register_offering event block, report_revenue closing, and whitelist_add body; removed duplicate constants - src/test.rs: accepted master version (reconciliation event completeness tests) - src/test_auth.rs: kept #[ignore] on freeze_offering test + kept master's unfreeze test - test_snapshots/: accepted master versions for all 6 conflicted snapshots
- Guard proptest::prelude::Arbitrary derive with #[cfg_attr(test)] on ProposalAction so it only applies during test builds - Add missing DataKey::ContractFlags variant (used by is_event_only / is_event_versioning_enabled but never declared in the enum) - Remove #[contracttype] from AmountValidationCategory and AmountValidationResult (internal types; not exposed in contract ABI) - Gate assert_operation_fails / assert_operation_succeeds in usage in the no-std lib compilation path - Remove stray closing brace in src/test.rs (remnant of conflict)
Contributor
Author
|
@thlpkee20-wq please i have resolved conflict, the CICD failed but not my error, it is from existing codebase and I can't fix everything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multisig Initialization Validation
Description
This Pull Request develops and hardens the Multisig Initialization Validation capability with production-grade behavior, explicit security assumptions, and deterministic test coverage (
#149).Changes
src/lib.rs:Admincan initialize the multisig logic (caller.require_auth() && caller == admin).MAX_MULTISIG_OWNERS = 20to prevent unbounded iteration.EVENT_MULTISIG_INIT(symbol_short!("ms_init")) emitted upon success to allow off-chain indexers to easily read the configuration state.src/test.rs:test_multisig_initmodule covers exact success and validation paths (admin only, duplicate entries, exceeded bounds).claim,report_revenue, missingTryFromValusages, etc.). The multisig modifications compiled correctly but due to broader test issues insrc/test.rs, the overallcargo testcommand fails at the moment for unrelated downstream reasons.docs/multisig-initialization-validation.md:Closes
Closes #149