Skip to content

Enhancement: Add pre-commit #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
M4hbod wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Enhancement: Add pre-commit #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44b4c63
Enhancement: Update linting configuration and requirements for flake8
M4hbod Sep 19, 2025
7cb0795
Enhancement: Add pre-commit configuration
M4hbod Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install flake8
pip install -r requirements/ci.txt
- name: Lint
run: |
# Stop the build if there are Python syntax errors or undefined names
Expand Down
10 changes: 10 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
repos:
- repo: https://github.com/PyCQA/flake8
rev: 7.3.0
hooks:
- id: flake8
name: flake8-syntax
args: [--count, '--select=E9,F63,F7,F82', --show-source, --statistics, --builtins="_"]
- id: flake8
name: flake8-style
args: [--count, --max-complexity=10, --max-line-length=88, --statistics]
Copy link
Owner

@Revisto Revisto Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in .pre-commit-config.yaml is inconsistent, it's using 3-4 spaces instead of the standard 2-space YAML indentation. Should be cleaned up.
Something like:

repos:
  - repo: https://github.com/PyCQA/flake8
    rev: 7.3.0
    hooks:
      - id: flake8
        name: flake8-syntax
        args: [--count, '--select=E9,F63,F7,F82', --show-source, --statistics, --builtins="_"]
      - id: flake8
        name: flake8-style
        args: [--count, --max-complexity=10, --max-line-length=88, --statistics]

2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.PHONY: generate-deps

generate-deps:
flatpak_pip_generator --build-isolation --requirements-file=requirements.txt -o python-dependencies --runtime=org.gnome.Sdk/x86_64/master
flatpak_pip_generator --build-isolation --requirements-file=requirements/base.txt -o python-dependencies --runtime=org.gnome.Sdk/x86_64/master
0 requirements.txt → requirements/base.txt
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions requirements/ci.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
flake8
3 changes: 3 additions & 0 deletions requirements/local.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-r base.txt
pre_commit
flake8