Skip to content

Conversation

@minosimo
Copy link

@minosimo minosimo commented Aug 11, 2025

Description

Replaced samples with more typical Rock Kit sound

Samples are from https://ivyaudio.com/freebies

(I am the creator of Ivy Audio, and give permission to use these samples. Will switch Scott Drums to gplv3 license soon)

Relates to #14

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Additional Notes

Let me know what you think of the sound. I'll want to adjust the editing and processing.

Replaced samples with more typical Rock Kit sound

Samples are from https://ivyaudio.com/freebies

(I am the creator of Ivy Audio, and give myself permission to use these samples)
@sepehr-rs
Copy link
Collaborator

Thanks a lot for your contribution @minosimo. This looks good to me, but I'll request a review from @Revisto too, as he might have some other thoughts about this.

@sepehr-rs sepehr-rs requested a review from Revisto August 12, 2025 02:19
@minosimo minosimo marked this pull request as draft August 12, 2025 08:03
@vanillajonathan
Copy link
Contributor

Note that the about dialog has a mention of where the drumkit is from so update that one.

@Revisto
Copy link
Owner

Revisto commented Aug 14, 2025

Hi @minosimo, thank you so much for implementing your rock kit samples into the drum machine <3

I'm going to keep this PR open till we make a sample kit switcher or something, so we can have multiple kits, such as the current one and the Rock kit you added.
Thanks.

@Revisto
Copy link
Owner

Revisto commented Dec 22, 2025

Well, I changed the default branch to main and removed the master branch, which caused this. Sorry about that. But about this pull request, we are close to having multiple kit samples since we added the custom samples feature. I will reach out to you once we have this feature.

I changed the target branch to main so it should be fixed now and no need to open a new PR, thanks.

@Revisto Revisto reopened this Dec 22, 2025
@Revisto Revisto changed the base branch from master to dev December 22, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants