feat(web): add Stage favicon to the web UI#27
Merged
Conversation
Copy favicon assets from the hosted Stage monorepo and add link tags to index.html so the browser tab shows the Stage icon.
There was a problem hiding this comment.
Code Review
This pull request adds standard favicon links to the index.html file. The review feedback suggests expanding the icon set to include higher-resolution versions, such as a 180x180 apple-touch-icon and a 192x192 PNG, to ensure a polished experience on high-DPI displays and mobile devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Stage favicon so the browser tab displays the Stage icon instead of the default blank icon. Assets copied from the hosted Stage monorepo.
Changes
favicon.ico,favicon-16.png, andfavicon-32.pngtopackages/web/public/<link>tags for all three favicon variants inpackages/web/index.htmlTesting
pnpm typecheckandpnpm lint— both pass