fix(web): hide non-functional comment button on Files-changed tab#24
Merged
Merged
Conversation
Drop the noop onComment handler that was making FileHeader render an inert "Comment on this file" button. Comment scaffolding stays in place for a future wiring.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
dastratakos
force-pushed
the
dastratakos/remove-file-comment-button
branch
from
bffaf0f to
943e7fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Files-changed tab was rendering a "Comment on this file" button in every file header, but clicking it did nothing because the handler was a noop. Drop the noop so the button stops appearing until the comment feature is actually wired up.
Changes
onComment={noop}(and thenoopconst) fromFileDiffSectioninpackages/web/src/components/files/file-diff-list.tsx.FileHeaderonly renders the comment button whenonCommentis supplied, so the button now stays hidden. TheonCommentscaffolding onFileHeaderis preserved for an upcoming follow-up.Testing
pnpm typecheckpnpm lint