-
Notifications
You must be signed in to change notification settings - Fork 21
chore(PLA-118): migrate to pnpm workspace (packages/cli, packages/types, packages/web) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dastratakos
merged 6 commits into
main
from
dean/pla-118-issue-10-migrate-to-pnpm-workspace-packagescli-packagestypes
May 3, 2026
+432
−301
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
93c5ee9
chore(PLA-118): migrate to pnpm workspace (packages/cli, packages/typ…
dastratakos 016a882
docs(PLA-118): point comment at packages/cli/src/schema.ts
dastratakos a7aec8a
fix(PLA-118): move @stage-cli/types to devDependencies in stagereview
dastratakos 30231c0
refactor(PLA-118): rename HunkRef to HunkReference to align with host…
dastratakos fd62d3d
docs(PLA-118): refresh agent docs to match new pnpm workspace layout
dastratakos f7bfaea
chore(PLA-118): keep workspace root named stagereview
dastratakos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,7 @@ | |
| "!**/node_modules", | ||
| "!**/dist", | ||
| "!**/web-dist", | ||
| "!drizzle" | ||
| "!**/drizzle" | ||
| ] | ||
| }, | ||
| "linter": { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workspace now has two packages named
stagereview(/package.jsonandpackages/cli/package.json), but these scripts still usepnpm --filter stagereview .... Per pnpm’s filtering docs, when multiple workspace packages share the same name, an unscoped name filter matches nothing; andpnpm-workspace.yamldocs state the root package is always included in the workspace. This meansbuild(and similarlydb:generate) can silently skip the CLI package, so CI/local runs may pass without actually buildingpackages/clior regenerating migrations.Useful? React with 👍 / 👎.