Conversation
cccb789 to
8dc0a6a
Compare
|
Your development orb has been published. It will expire in 30 days. |
tonidero
left a comment
There was a problem hiding this comment.
Just a comment... But I won't block the PR because of this :)
| POLL_INTERVAL="${POLL_INTERVAL:-30}" | ||
| TIMEOUT="${TIMEOUT:-1800}" | ||
|
|
||
| if [[ -z "${COORDINATES:-}" ]]; then |
There was a problem hiding this comment.
TBH, I do prefer to avoid shell scripts since they are harder to read... But I do guess it's the most compatible approach that avoids having to install anything... It might be worth running on a node machine and use typescript instead... Or even move the whole script to the fastlane plugin so we can actually add tests for it?
But I wouldn't say it's a blocker. I'm ok keeping it like this since it indeed can keep the job minimal
ajpallares
left a comment
There was a problem hiding this comment.
Looks good!
I get Toni's comments, and I agree that ideally we should be able to add tests for this. But I also see the point of using a shell script so that the job can remain very lightweight.
I'm ok with either approach since the poll with timeout is fairly straightforward
Description
Adds a job and a step named
await-maven-central-package, which will wait (with timeout) for a package to become available in Maven Central. Usage looks like this:Integrated here: RevenueCat/purchases-android#3292