Skip to content

Adds await-maven-central-package #46

Open
JayShortway wants to merge 1 commit intomainfrom
await-maven-central-package
Open

Adds await-maven-central-package #46
JayShortway wants to merge 1 commit intomainfrom
await-maven-central-package

Conversation

@JayShortway
Copy link
Copy Markdown
Member

@JayShortway JayShortway commented Mar 31, 2026

Description

Adds a job and a step named await-maven-central-package, which will wait (with timeout) for a package to become available in Maven Central. Usage looks like this:

      - revenuecat/await-maven-central-package:
          coordinates: |
            com.revenuecat.purchases:purchases:x.y.z
            com.revenuecat.purchases:purchases-ui:x.y.z

Integrated here: RevenueCat/purchases-android#3292

@JayShortway JayShortway self-assigned this Mar 31, 2026
@JayShortway JayShortway force-pushed the await-maven-central-package branch from cccb789 to 8dc0a6a Compare April 1, 2026 11:16
@RCGitBot
Copy link
Copy Markdown
Contributor

RCGitBot commented Apr 1, 2026

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/revenuecat/sdks-common-config?version=dev:8dc0a6a1e3cff28bb5393175d0a1c4dad95e5ec5

Copy link
Copy Markdown
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment... But I won't block the PR because of this :)

POLL_INTERVAL="${POLL_INTERVAL:-30}"
TIMEOUT="${TIMEOUT:-1800}"

if [[ -z "${COORDINATES:-}" ]]; then
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I do prefer to avoid shell scripts since they are harder to read... But I do guess it's the most compatible approach that avoids having to install anything... It might be worth running on a node machine and use typescript instead... Or even move the whole script to the fastlane plugin so we can actually add tests for it?
But I wouldn't say it's a blocker. I'm ok keeping it like this since it indeed can keep the job minimal

Copy link
Copy Markdown
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I get Toni's comments, and I agree that ideally we should be able to add tests for this. But I also see the point of using a shell script so that the job can remain very lightweight.

I'm ok with either approach since the poll with timeout is fairly straightforward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants