Conversation
| command: bundle exec fastlane github_release_current_version | ||
|
|
||
| workflows: | ||
| on-action-upgrade-hybrid-common: |
There was a problem hiding this comment.
We will need to change PHC to avoid calling this non-existing workflow after merging this to main
There was a problem hiding this comment.
Great point! I think this should be enough RevenueCat/purchases-hybrid-common#1583
| if git_tag_exists(tag: version_number, remote: true, remote_name: 'origin') | ||
| raise "git tag with version #{version_number} already exists!" | ||
| end | ||
| def get_billing_client_version(android_version) |
There was a problem hiding this comment.
Wonder if we should extract this to the fastlane plugin so it can be shared with PHC... Not a blocker though :)
There was a problem hiding this comment.
Hmm yea, wouldn't that require us to make it a lane instead of a function?
There was a problem hiding this comment.
Indeed.... so yeah, I guess it's not that complex and not that reused just now that we need to do this I think
| sdk_version, | ||
| "[#{ios_version}](https://github.com/RevenueCat/purchases-ios/releases/tag/#{ios_version})", | ||
| "[#{android_version}](https://github.com/RevenueCat/purchases-android/releases/tag/#{android_version})", | ||
| "N/A", |
There was a problem hiding this comment.
Hmm good to leave this like this for now I think. Once we've merge this and some time passes, it might be worth removing the column entirely.
JayShortway
force-pushed
the
release-automations
branch
from
1eaac03 to
de47d53
Compare
JayShortway
force-pushed
the
delete-datetime
branch
from
282bf65 to
41bb70e
Compare
JayShortway
force-pushed
the
release-automations
branch
from
de47d53 to
f7ab356
Compare
JayShortway
force-pushed
the
delete-datetime
branch
from
41bb70e to
d7d3d41
Compare
JayShortway
force-pushed
the
release-automations
branch
2 times, most recently
from
f7ab356 to
93308b4
Compare
JayShortway
force-pushed
the
delete-datetime
branch
from
d7d3d41 to
2bfea45
Compare
purchases-kmp is removing the `on-action-upgrade-hybrid-common` workflow (RevenueCat/purchases-kmp#770), so PHC should stop triggering it. Made-with: Cursor
| command: bundle exec fastlane github_release_current_version | ||
|
|
||
| workflows: | ||
| on-action-upgrade-hybrid-common: |
There was a problem hiding this comment.
Great point! I think this should be enough RevenueCat/purchases-hybrid-common#1583
JayShortway
force-pushed
the
release-automations
branch
from
93308b4 to
1847506
Compare
JayShortway
force-pushed
the
delete-datetime
branch
2 times, most recently
from
73c8e62 to
dd8b696
Compare
JayShortway
force-pushed
the
release-automations
branch
from
1847506 to
5cc4675
Compare
JayShortway
force-pushed
the
delete-datetime
branch
from
dd8b696 to
341bcd2
Compare
JayShortway
force-pushed
the
release-automations
branch
2 times, most recently
from
e34cb7c to
c7c32ce
Compare
JayShortway
force-pushed
the
delete-datetime
branch
from
341bcd2 to
0a4c17e
Compare
JayShortway
force-pushed
the
release-automations
branch
from
c7c32ce to
831aa91
Compare
3 participants
Motivation
I'm working on improving the integration experience of purchases-kmp, by avoiding the need for app developers to add the purchases-hybrid-common dependency manually as this adds friction and prevents properly testing Kotlin/Native modules that depend on purchases-kmp. Instead, we will be embedding purchases-ios directly in purchases-kmp, handling all complexity for the app developers.
Description
This PR fixes release automations after migrating both the iOS and Android targets away from PHC. This mainly involves updating the
VERSIONS.mdfile correctly upon release.