Fix missing purchase/restore completion callbacks in proxy paywall path#750
Draft
facumenzella wants to merge 3 commits intomainfrom
Draft
Fix missing purchase/restore completion callbacks in proxy paywall path#750facumenzella wants to merge 3 commits intomainfrom
facumenzella wants to merge 3 commits intomainfrom
Conversation
…roxy paywall path The IosPaywallProxyDelegate (used for non-footer paywalls) was missing implementations for didFinishPurchasingWith and didFinishRestoringWith from the DelegateWrapperProtocol. This caused onPurchaseCompleted to never fire and onRestoreCompleted to never fire through the proxy path, while dismissRequest still fired on purchase success — making it impossible for developers to control paywall dismissal after a purchase. Adds buildCustomerInfo() to parse PHC dictionary format back to CustomerInfo model, along with comprehensive tests and an API test. Fixes #736 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…wallowing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dismissRequestwas called butonPurchaseCompletednever fired on non-footer paywallsIosPaywallProxyDelegatewas missingdidFinishPurchasingWithanddidFinishRestoringWithdelegate method implementations from theDelegateWrapperProtocolbuildCustomerInfo()to parse PHC dictionary format back intoCustomerInfomodel (needed because the proxy path uses dictionary-based protocol, not typed)onRestoreCompletedwhich had the same issueTest plan
onPurchaseCompletedfires beforedismissRequeston non-footer paywallsonRestoreCompletedfires on non-footer paywallsbuildCustomerInfodictionary parsing cover full map, minimal map, missing fields, and enum parsing🤖 Generated with Claude Code