[DO NOT MERGE] Migrates to Kotlin's upcoming SwiftPM import feature#598
Draft
JayShortway wants to merge 8 commits intomainfrom
Draft
[DO NOT MERGE] Migrates to Kotlin's upcoming SwiftPM import feature#598JayShortway wants to merge 8 commits intomainfrom
JayShortway wants to merge 8 commits intomainfrom
Conversation
6cbd13f to
590f65c
Compare
a1824a9 to
3be52a9
Compare
3be52a9 to
9401737
Compare
9401737 to
21cc92d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the library to make use of Kotlin's upcoming SwiftPM import feature. This Kotlin feature is in preview, and still has the following rough edges to smooth out:
embedAndSignAppleFrameworkForXcode) will have to runintegrateLinkagePackageto generate the_internal_linkage_SwiftPMImportpackage and commit it to version control.objcnamespackage. This shows unresolved type errors in the IDE, but it builds and runs fine.Hard to structure the project when multiple modules depend on the same SPM package. Cannot influence the namespace for the generated Kotlin bindings, nor are they exposed as if they were anWorkaround: setapi()dependency.kotlin.mpp.enableCInteropCommonization=trueingradle.properties.developers of purchases-kmptitan-208integrateLinkagePackagecreates aproject.pbxprojfile that fails validation by thecheckSyntheticImportProjectIsCorrectlyIntegratedtask which is run at build time. Can be silenced using thekotlin.kmp.suppressXcodeIntegrationCheck=trueproperty.developers of purchases-kmpNote for review
I would highly recommend reviewing this 1 commit at a time. That reduces the complexity considerably. Most of the changed files are due to import statements. I also added a migration guide.
Release plan
My plan is to release this branch as
3.0.0-dev01after approval, without merging it. Let me know what you think of that too.