Conversation
vegaro
added
pr:fix
vegaro
commented
Sep 30, 2025
| @JvmOverloads | ||
| fun launch( | ||
| offeringIdentifier: String, | ||
| offeringIdentifier: String?, |
Member
Author
There was a problem hiding this comment.
this is required to be able to call launch without an offering identifier. I can't use the launch that accepts an Offering because I need the presentedOfferingContext as parameter
Contributor
There was a problem hiding this comment.
Hmm I think presentedOfferingContext should always be null if the offering identifier/offering is null right? If so, I think we should be able to use that one?
Member
Author
There was a problem hiding this comment.
oh, ok, so if offering and presentedOfferingContext are null, call the one with Offering. Otherwise this one. Good to know!
Member
Author
There was a problem hiding this comment.
I need to pick your brain:
- If I remove
?and keep the@JvmOverloads, there are two conflicting APIs in Java sincelauncher.launch(null, null)could belaunch(Offering,ParcelizableFontProvider)andlaunch(String,PresentedOfferingContext) - If I don't use
@JvmOverloadsI can't use the defaults in the optional parameters inlaunchandlaunchIfNeeded
Any ideas besides creating new calls? Or migrating this to Kotlin lol
Member
Author
There was a problem hiding this comment.
oh I know what to do! @JvmName("launchWithOfferingId")
tonidero
approved these changes
Sep 30, 2025
Contributor
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
I think we don't need to make the parameter nullable and can just rely on the launch method that takes a nullable offering? Other than that, this looks good!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 309 309
Lines 11595 11595
Branches 1597 1597
=======================================
Hits 9039 9039
Misses 1859 1859
Partials 697 697 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
**This is an automatic release.** > [!WARNING] > If you don't have any login system in your app, please make sure your one-time purchase products have been correctly configured in the RevenueCat dashboard as either consumable or non-consumable. If they're incorrectly configured as consumables, RevenueCat will consume these purchases. This means that users won't be able to restore them from version 9.0.0 onward. > Non-consumables are products that are meant to be bought only once, for example, lifetime subscriptions. ## RevenueCat SDK ### ✨ New Features * Add Airbridge device ID subscriber attribute (#2696) via Lim Hoang (@limdauto) * Enable Test Store (#2685) via Antonio Pallares (@ajpallares) ## RevenueCatUI SDK ### ✨ New Features * Expose `launch` and `launchIfNeeded` to Java (#2695) via Cesar de la Vega (@vegaro) ### Customer Center #### 🐞 Bugfixes * Fix Expired badge in Customer Center dark mode (#2693) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Add CODEOWNERS (#2664) via Facundo Menzella (@facumenzella) * Adds new tab ID properties to `TabsComponent`. (#2577) via JayShortway (@JayShortway) * Bump fastlane-plugin-revenuecat_internal from `401d148` to `7508f17` (#2697) via dependabot[bot] (@dependabot[bot]) * Reimplement placeholder with Modifier.Node (#2677) via Jaewoong Eum (@skydoves) * Remove unused kotlinCompilerExtensionVersion (#2691) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2667) via RevenueCat Git Bot (@RCGitBot) Co-authored-by: revenuecat-ops <[email protected]>
vegaro
added a commit
that referenced
this pull request
Oct 15, 2025
Required for RevenueCat/purchases-unity#649 (cherry picked from commit 656542a)
vegaro
added a commit
that referenced
this pull request
Oct 15, 2025
vegaro
added a commit
that referenced
this pull request
Oct 15, 2025
Merged
vegaro
added a commit
that referenced
this pull request
Oct 15, 2025
vegaro
added a commit
that referenced
this pull request
Oct 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
## RevenueCat SDK > [!NOTE] > This release brings all non-breaking changes between SDK versions 9.6.0 and 9.11.0 to major 8, so developers that don't/can't use major 9, can still get the latest updates. meant to be bought only once, for example, lifetime subscriptions. ### ✨ New Features * Adds new experimental `storefrontLocale` APIs. (#2726) via JayShortway (@JayShortway) * Turn on Video Component (#2725) via Jacob Rakidzich (@JZDesign) * Add support for the Test Store (#2710) via Toni Rico (@tonidero) * Add Airbridge device ID subscriber attribute (#2696) via Lim Hoang (@limdauto) * Enable Test Store (#2685) via Antonio Pallares (@ajpallares) ### 🐞 Bugfixes * Fix deadlock in `allowSharingPlayStoreAccount` (#2707) via Cesar de la Vega (@vegaro) ## RevenueCatUI SDK ### Paywallv2 #### ✨ New Features * Expose `launch` and `launchIfNeeded` to Java (#2695) via Cesar de la Vega (@vegaro) #### 🐞 Bugfixes * Fix bundled font families when using assets folder (#2672) via Toni Rico (@tonidero) ### Customer Center #### ✨ New Features * Add Customer Center per-view listener for hybrids (#2713) via Facundo Menzella (@facumenzella) * Display Virtual Currencies in Customer Center (#2652) via Will Taylor (@fire-at-will) #### 🐞 Bugfixes * Fixes more Icons crashing with `NoClassDefFoundError` when using Material 1.4.0 (#2732) via Cesar de la Vega (@vegaro) * Fix potential `NoClassDefFoundError` crash finding `Icons` caused by material3 1.4.0 (#2727) via Cesar de la Vega (@vegaro) * Fix Expired badge in Customer Center dark mode (#2693) via Cesar de la Vega (@vegaro) * Fix promo offer button CTA in Customer Center (#2682) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Add test store maestro test (#2711) via Toni Rico (@tonidero) * Finalize video component to include a checksum, and optimize memory usage for large file downloads (#2717) via Jacob Rakidzich (@JZDesign) * Add `TestStoreSimulatedPurchaseError` error code (#2716) via Toni Rico (@tonidero) * Bump fastlane-plugin-revenuecat_internal from `3f7fffc` to `25c7fb8` (#2721) via dependabot[bot] (@dependabot[bot]) * Disable offline entitlements in test store (#2718) via Toni Rico (@tonidero) * Add E2E Test app for integration tests (#2715) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2714) via RevenueCat Git Bot (@RCGitBot) * Bump fastlane-plugin-revenuecat_internal from `a8770fd` to `3f7fffc` (#2712) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `e555afb` to `a8770fd` (#2708) via dependabot[bot] (@dependabot[bot]) * Correct Opt In for FileRepository (#2709) via Jacob Rakidzich (@JZDesign) * Paywalls -> Video Component (#2680) via Jacob Rakidzich (@JZDesign) * Update fastlane-plugin-revenuecat_internal to e555afb (#2705) via Cesar de la Vega (@vegaro) * [EXTERNAL] Fix incorrect exception use in test (#2674) via @nikit19 (#2703) via Toni Rico (@tonidero) * Add CODEOWNERS (#2664) via Facundo Menzella (@facumenzella) * Adds new tab ID properties to `TabsComponent`. (#2577) via JayShortway (@JayShortway) * Bump fastlane-plugin-revenuecat_internal from `401d148` to `7508f17` (#2697) via dependabot[bot] (@dependabot[bot]) * Reimplement placeholder with Modifier.Node (#2677) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2667) via RevenueCat Git Bot (@RCGitBot) * Bump fastlane-plugin-revenuecat_internal from `a6dc551` to `401d148` (#2683) via dependabot[bot] (@dependabot[bot]) * Bump rexml from 3.4.1 to 3.4.2 (#2676) via dependabot[bot] (@dependabot[bot]) * Add 8.24.0 CHANGELOG to main (#2662) via Toni Rico (@tonidero) * Bump fastlane-plugin-revenuecat_internal from `489faef` to `a6dc551` (#2673) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `7d97553` to `489faef` (#2671) via dependabot[bot] (@dependabot[bot]) * File Repository (#2634) via Jacob Rakidzich (@JZDesign) Co-authored-by: revenuecat-ops <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for RevenueCat/purchases-unity#649