Skip to content

Add validate_version_not_in_maven_central lane#101

Merged
tonidero merged 1 commit intomainfrom
add-validate_version_not_in_maven_central
Nov 12, 2025
Merged

Add validate_version_not_in_maven_central lane#101
tonidero merged 1 commit intomainfrom
add-validate_version_not_in_maven_central

Conversation

@tonidero
Copy link
Copy Markdown
Contributor

@tonidero tonidero commented Nov 6, 2025

This moves the lane originally developed in android here: RevenueCat/purchases-android#2799

This way, the logic can be shared with PHC and KMP SDKs


module Fastlane
module Actions
class ValidateVersionNotInMavenCentralAction < Action
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this doesn't move the logic to calculate what artifacts to check for from the android repo since that's mostly in gradle, with a small bit of logic in fastlane. We might want to consider creating a gradle plugin we can share with that part of the logic, but for now, this felt like the simpler approach.

@tonidero tonidero marked this pull request as ready for review November 6, 2025 15:22
@tonidero tonidero requested a review from a team November 6, 2025 15:22
@tonidero tonidero changed the title Add validate_version_not_in_maven_central lane Add validate_version_not_in_maven_central lane Nov 6, 2025
allow(ENV).to receive(:[]).with("FETCH_PUBLICATIONS_USER_TOKEN_MAVEN_CENTRAL").and_return(auth_token)
end

context 'when version does not exist in Maven Central' do
Copy link
Copy Markdown
Member

@rickvdl rickvdl Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Copy Markdown
Member

@rickvdl rickvdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Copy Markdown
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@tonidero tonidero merged commit 1e3e3fd into main Nov 12, 2025
1 check passed
@tonidero tonidero deleted the add-validate_version_not_in_maven_central branch November 12, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants