feat: make modern hubs generally available #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has occurred to me that before we can merge this, we'll need to handle "hub game" shortcodes in messages and forum topic comments, probably with the creation of a new This is still probably good to review, but can't be merged until that piece of work is done. |
Jamiras
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cuts over legacy hubs to the new Inertia.js hubs:
/hub/{gameSet}./game/{game}302 redirect to their corresponding modern hub page./hubs/or/hub/{2-5}.FEATURE_ENABLE_MODERN_HUBSenv var has been removed.Additionally, I've removed all legacy hub code from gameInfo.blade.php (game list service stuff).
I've also relocated related events to the sidebar:
Next steps:
GameAlternatives.SearchTypeand break hub games out of search.