Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build ui for similar game suggestions #3058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wescopeland
Copy link
Member

This PR finishes the migration of the game suggestions pages to React by building out the UI for /game/{game}/suggestions.

This page is functionally equivalent with the one introduced in #3045, with the exception of a new buttonlink that takes the user to their personalized suggestions page (/games/suggestions):

Screenshot 2025-01-13 at 7 35 54 PM

@wescopeland wescopeland requested a review from a team January 14, 2025 00:37
className={baseButtonVariants({ size: 'sm', className: 'gap-1' })}
>
<LuUser className="size-4" />
{t('See games picked just for you')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs some additional text. Since we're on a page for finding "games similar to X", this suggests that it would further filter it down to "games just for you similar to X".

I'm not coming up with any good suggestions on how to improve it though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shooting from the hip, here's four ideas:

  • "Explore games based on your history"
  • "View your personal game matches"
  • "View all your recommended games"
  • "See your full recommendation feed"

Do you like any of these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last two are good.

I like the wording on the third, but the last seems to be the most accurate description.

Maybe "View personal suggestions from our entire library"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but it may be too long:
Screenshot 2025-01-16 at 8 17 04 PM

I went with option 4, happy to change it though:
Screenshot 2025-01-16 at 8 17 53 PM

</div>
</div>

<GameSuggestionsDataTable />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how easy it would be to remove the relatedGame icon from every row, as it's implied by the page header.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took some creativity, but should be updated in latest:
Screenshot 2025-01-16 at 8 18 31 PM

The only wording I'm not so confident in is the similar beaten/mastered verbiage, ie: "Also mastered by same players". Maybe it actually sounds okay and it only sounds weird to me because I've been reciting it in my head over and over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants