-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build ui for similar game suggestions #3058
base: master
Are you sure you want to change the base?
feat: build ui for similar game suggestions #3058
Conversation
className={baseButtonVariants({ size: 'sm', className: 'gap-1' })} | ||
> | ||
<LuUser className="size-4" /> | ||
{t('See games picked just for you')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs some additional text. Since we're on a page for finding "games similar to X", this suggests that it would further filter it down to "games just for you similar to X".
I'm not coming up with any good suggestions on how to improve it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shooting from the hip, here's four ideas:
- "Explore games based on your history"
- "View your personal game matches"
- "View all your recommended games"
- "See your full recommendation feed"
Do you like any of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last two are good.
I like the wording on the third, but the last seems to be the most accurate description.
Maybe "View personal suggestions from our entire library"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</div> | ||
</div> | ||
|
||
<GameSuggestionsDataTable /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR finishes the migration of the game suggestions pages to React by building out the UI for
/game/{game}/suggestions
.This page is functionally equivalent with the one introduced in #3045, with the exception of a new buttonlink that takes the user to their personalized suggestions page (
/games/suggestions
):