fix(leaderboard): change ->authorUser to ->developer #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not, at least not on staging. I'm guessing most users don't update leaderboards after they've been published. |
Jamiras
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea how this is working in prod.
Locally it doesn't appear to be possible to edit a leaderboard without RALibretro throwing an error.
->authorUserwas renamed to->developerand this line of code wasn't changed.In prod, changes are made but
$originalAuthorappears to not be set, which results in server comments not being recorded. I cannot explain why prod exhibits a different behavior from local development.