Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add max-w-fit classname to avatar components #2982

Merged

Conversation

wescopeland
Copy link
Member

One less thing to remember. This tiny change is intended to mitigate the need to have a div wrapper around these elements. Currently without a max-w-fit wrapper, if the avatar components appear within a table cell, the tooltip will appear when hovering over any part of the cell rather than just the avatar's title label/image.

Before

<div className="max-w-fit">
  <UserAvatar {...user} />
</div>

After

<UserAvatar {...user} />

@wescopeland wescopeland requested a review from a team December 25, 2024 20:56
@wescopeland wescopeland merged commit 81df6c6 into RetroAchievements:master Jan 1, 2025
8 checks passed
@wescopeland wescopeland deleted the avatar-max-w-fit-classname branch January 1, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants