Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Developer Feed page to React #2981

Merged

Conversation

wescopeland
Copy link
Member

This PR migrates the Developer Feed page to React. Additionally, the legacy Active Players stuff is all dropped, as this was the last page that was using it.

Several performance optimizations have been made to the page's underlying queries. With a primed active players cache, on my local machine the page goes from taking ~1.1s to ~110ms to load. A migration is included in the PR to add an index.

How to test this PR:

sail artisan migrate

Then navigate to http://localhost:64000/user/{user}/developer/feed.

Before
Screenshot 2024-12-25 at 3 13 06 PM

After
Screenshot 2024-12-25 at 2 12 02 PM

@wescopeland wescopeland requested a review from a team December 25, 2024 20:13
@wescopeland wescopeland merged commit 3dfc81a into RetroAchievements:master Jan 2, 2025
8 checks passed
@wescopeland wescopeland deleted the react-developer-feed branch January 2, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants