-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fully migrate hash management to filament #2975
base: master
Are you sure you want to change the base?
feat: fully migrate hash management to filament #2975
Conversation
@can('manage', App\Models\GameHash::class) | ||
<x-game.link-buttons.game-link-button | ||
icon="💾" | ||
:href="route('game.hash.manage', ['game' => $game])" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where to put this note, but the Manage Hashes buttons still exists on the Supported Game Files page and does correctly link to the filament page, so this didn't remove that.
Conversely, the Manage Hashes link in the Dev box on the game page is now broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the Manage Hashes devbox link in latest.
I removed this Blade UI because, unless I'm mistaken, it's completely handled by React now, so this is dead code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For additional context, would it be possible to display the hash on the dialog that pops up when editing a hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't appear to be any way to view the audit log for hash records.
Are there plans to expose the legacy audit log comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, these should still be exposed via the View Comments action:
Right now, this button only lights up if there are >1 non-automated comments:
Tables\Actions\Action::make('view-comments')
->color($nonAutomatedCommentsCount > 0 ? 'info' : 'gray')
->label("View Comments ({$nonAutomatedCommentsCount})")
->url(route('game.hashes.comment.index', ['game' => $this->getOwnerRecord()->id])),
This PR drops the Blade manage hashes page, migrating hash management capabilities fully into Filament.
Hash management for a game is now a dedicated subpage (to facilitate proper linking) instead of a relation manager. However, all the existing relation manager code has been ported over 1:1.