Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow developers to delete unofficial achievements #2969

Merged

Conversation

wescopeland
Copy link
Member

@wescopeland wescopeland commented Dec 22, 2024

This PR grants developers the ability to delete unofficial achievements in the management app. An achievement may be soft-deleted if:

  • The achievement is sitting in unofficial.
  • The achievement has 0 unlocks.

This should eliminate the need to have "[void]" achievements, or to attach achievements to things like hub games.

Brave.Browser.mp4

Developers also have the ability to restore soft-deleted achievements:
Screenshot 2024-12-22 at 4 09 00 PM

Deletes and restores are recorded on the achievement's audit log:
Screenshot 2024-12-22 at 4 10 40 PM

Additionally, I've verified that soft deleted achievements no longer appear in RALibretro's assets list:
Screenshot 2024-12-27 at 4 23 26 PM

@wescopeland wescopeland requested a review from a team December 22, 2024 21:01
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not part of this PR, but restoring a deleted record adds audit information showing all the fields even though they technically weren't modified.

@Jamiras
Copy link
Member

Jamiras commented Dec 30, 2024

Also, unrelated to this PR, searching for achievement IDs seems to be matching the badge name:
image

mysql> select BadgeName from Achievements where ID=176447;
+-----------+
| BadgeName |
+-----------+
| 196740    |
+-----------+

@wescopeland wescopeland merged commit b9781df into RetroAchievements:master Jan 1, 2025
8 checks passed
@wescopeland wescopeland deleted the delete-void-achievements branch January 1, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants