feat: Add unified document to feed entries #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
- Coverage 68.57% 68.46% -0.11%
==========================================
Files 428 427 -1
Lines 23011 22872 -139
==========================================
- Hits 15779 15659 -120
+ Misses 7232 7213 -19 ☔ View full report in Codecov by Sentry. |
koutst
reviewed
Feb 28, 2025
src/feed/models.py
Outdated
| ResearchhubUnifiedDocument, | ||
| on_delete=models.CASCADE, | ||
| null=True, | ||
| blank=True, |
There was a problem hiding this comment.
Should we make it a non nullable field or do we want to avoid creating that sort of requirement on feed entries?
koutst
approved these changes
Feb 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a direct relation to unified documents to feed entries.
This is primarily for performance reasons. Since different entity types managed in the feed can have their relation to the unified document on a different level, this change makes sure that we can easily join the feed with the unified document uniformly.