-
Notifications
You must be signed in to change notification settings - Fork 45
FEAT: Add STRIDE based threat modeling #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@Aaditya-G please review |
|
@staru09 please open an issue and link it to this PR |
Aaditya-G
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@staru09 with this PR can you refactor a bit
keep all system prompts inside one folder
rename system_prompt.txt to system_promot_maestro.txt for better understanding
additionally in the PR itself, have a reference to STRIDE.
also, update README.md to let end user know about using the new methodology.
Updated the file names based on the framework
Added a link for the same
Done, please review |
CoderMayhem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current generate report looks a bit superficial, we can make it more verbose. Take a look at the reports generated through MAESTRO and see how we can make the STRIDE reports more insightful for the user.
The aim of the report is to give the user deep context into the threat model of their AI Agent.
|
Makes sense, let me go through it. |
|
Hi @CoderMayhem, please see if this report is any better, I'll update the PR if this one's fine. |
|
looks better, need to test the system prompt for consistency across various agent frameworks. @staru09 can you do that? generate the report for different framework examples and see if the reports are consistent in format and content quality |
|
cool, I'll keep you posted with the results. |
Related to #43 .
STRIDE Model :- This framework enables developers to classify potential threats and ensure software systems maintain confidentiality, integrity, and availability. By assessing risks early in the development process, STRIDE allows for the implementation of effective security protections.
For more details refer this.
This is the sample report it created for the
agentchat_graph.json