Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

add local Open Sans fonts #4

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

add local Open Sans fonts #4

wants to merge 25 commits into from

Conversation

lysenko
Copy link

@lysenko lysenko commented Dec 3, 2018

What this PR does?

Test

Tasks

eriktrom and others added 25 commits March 2, 2018 15:48
fixes alvarcarto#57

Reason: Chrome 63+ does closes socket without waiting for close frame
from server. Upstream WS library then throws on server. Puppeteer was
upgraded to handle this in the following commits

- puppeteer/puppeteer@80078d9
- puppeteer/puppeteer@fc2a104

Trace of this problem can be found by following these links:

- alvarcarto#57
- websockets/ws#1256
- https://bugs.chromium.org/p/chromium/issues/detail?id=798194#c6
fixes alvarcarto#57

Reason: Chrome 63+ does closes socket without waiting for close frame
from server. Upstream WS library then throws on server. Puppeteer was
upgraded to handle this in the following commits

- puppeteer/puppeteer@80078d9
- puppeteer/puppeteer@fc2a104

Trace of this problem can be found by following these links:

- alvarcarto#57
- websockets/ws#1256
- https://bugs.chromium.org/p/chromium/issues/detail?id=798194#c6

Signed-off-by: Justin Culbertson <[email protected]>
…Idle' -> networkIdle2

Signed-off-by: Justin Culbertson <[email protected]>
…e_puppeteer_with_ws_fix

Conflicts:
	package.json
	src/core/pdf-core.js
	yarn.lock
@cfourt
Copy link

cfourt commented Dec 3, 2018

nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants